-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): make to convert null to N/A in view results #19316
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19316 +/- ##
==========================================
- Coverage 66.65% 66.65% -0.01%
==========================================
Files 1672 1672
Lines 64611 64615 +4
Branches 6505 6506 +1
==========================================
+ Hits 43066 43067 +1
- Misses 19862 19864 +2
- Partials 1683 1684 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* fix(explore): make to convert null to N/A in view results * fix(explore): make to null formatter move before timeFormatter
* fix(explore): make to convert null to N/A in view results * fix(explore): make to null formatter move before timeFormatter (cherry picked from commit 468c5ca)
* fix(explore): make to convert null to N/A in view results * fix(explore): make to null formatter move before timeFormatter
SUMMARY
NULL values not showing up in View Results in Explore
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
TESTING INSTRUCTIONS
How to reproduce the issue
ADDITIONAL INFORMATION