Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(explore): make to convert null to N/A in view results #19316

Merged
merged 2 commits into from
Mar 23, 2022
Merged

fix(explore): make to convert null to N/A in view results #19316

merged 2 commits into from
Mar 23, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Mar 22, 2022 •
edited
Loading

SUMMARY

NULL values not showing up in View Results in Explore

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

AFTER:
image

TESTING INSTRUCTIONS

How to reproduce the issue

  1. Go to Chart Table. (can try with cleaned_sales_data datasets)
  2. Set the Group BY as territorry field
  3. Set the Metrics as SUM(price_each)
  4. Run the chart
  5. Table has the null value, this is displayed as N/A
  6. But in View results, Table don't show null value as N/A like viz chart table.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #19316 (308e39c) into master (d10a3d8) will decrease coverage by 0.00%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master   #19316      +/-   ##
==========================================
- Coverage   66.65%   66.65%   -0.01%     
==========================================
  Files        1672     1672              
  Lines       64611    64615       +4     
  Branches     6505     6506       +1     
==========================================
+ Hits        43066    43067       +1     
- Misses      19862    19864       +2     
- Partials     1683     1684       +1
Flag Coverage Δ
javascript 51.33% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/explore/components/DataTableControl/index.tsx 71.62% <25.00%> (-2.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d10a3d8...308e39c. Read the comment docs.

@zhaoyongjie zhaoyongjie self-requested a review March 23, 2022 03:00
zhaoyongjie
zhaoyongjie approved these changes Mar 23, 2022
View reviewed changes
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 468c5ca into apache:master Mar 23, 2022
michael-hoffman-26 pushed a commit to nielsen-oss/superset that referenced this pull request Mar 23, 2022
@prosdev0107
fix(explore): make to convert null to N/A in view results (apache#19316)
444e042 
* fix(explore): make to convert null to N/A in view results

* fix(explore): make to null formatter move before timeFormatter
villebro pushed a commit that referenced this pull request Apr 3, 2022
@prosdev0107 @villebro
fix(explore): make to convert null to N/A in view results (#19316)
baeb36f 
* fix(explore): make to convert null to N/A in view results

* fix(explore): make to null formatter move before timeFormatter

(cherry picked from commit 468c5ca)
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@prosdev0107 @philipher29
fix(explore): make to convert null to N/A in view results (apache#19316)
baa8403 
* fix(explore): make to convert null to N/A in view results

* fix(explore): make to null formatter move before timeFormatter
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 and removed 🚢 2.0.1 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomedina248 diegomedina248 diegomedina248 approved these changes

@zhaoyongjie zhaoyongjie zhaoyongjie approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 Preset-Patch size/S 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@prosdev0107 @zhaoyongjie @diegomedina248 @mistercrunch @rusackas @villebro